Skip to content

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Aug 31, 2023

This PR pins framework_starlette: anyio to < v4.0.0

anyio is used for test_exception_in_middleware test in Starlette: encode/starlette#1157
However, v4.0.0 of anyio creates breaking changes to our tests (but not the instrumentation): https://github.com/agronholm/anyio/releases/tag/4.0.0

This should be kept in our tests until Starlette v0.17.0 is no longer within New Relic's support window (January 23, 2024)

@github-actions
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Aug 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.45%. Comparing base (faaccd0) to head (56ff7c5).
⚠️ Report is 1011 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
- Coverage   81.47%   81.45%   -0.02%     
==========================================
  Files         186      186              
  Lines       18700    18700              
  Branches     3278     3278              
==========================================
- Hits        15235    15233       -2     
  Misses       2533     2533              
- Partials      932      934       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lrafeei lrafeei marked this pull request as ready for review August 31, 2023 23:16
@lrafeei lrafeei requested a review from a team August 31, 2023 23:16
@umaannamalai umaannamalai merged commit b1be563 into main Sep 1, 2023
@umaannamalai umaannamalai deleted the pin-anyio-version branch September 1, 2023 17:33
@umaannamalai umaannamalai added this to the v9.1.0 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants