forked from Ethernal-Tech/admin-module
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: autocli for adminmodule #ntrn-348 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
NeverHappened
wants to merge
7
commits into
master
Choose a base branch
from
feat/autocli
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0404f85
tmp: remove manual tx's
NeverHappened 16ec389
tmp 2
NeverHappened 1f27b07
add autocli enhance command
NeverHappened 4fd3225
Revert "tmp: remove manual tx's"
NeverHappened 02335cd
test: enhance set to true, and remove queries and txs
NeverHappened c4b55d7
add serviceName
NeverHappened 7a28e65
cleanup
NeverHappened File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package adminmodule | ||
|
|
||
| import ( | ||
| autocliv1 "cosmossdk.io/api/cosmos/autocli/v1" | ||
| "cosmossdk.io/client/v2/autocli" | ||
| ) | ||
|
|
||
| var _ autocli.HasAutoCLIConfig = AppModule{} | ||
|
|
||
| func (am AppModule) AutoCLIOptions() *autocliv1.ModuleOptions { | ||
| return &autocliv1.ModuleOptions{ | ||
| Query: &autocliv1.ServiceCommandDescriptor{ | ||
| Service: "cosmos.adminmodule.adminmodule.Query", | ||
| RpcCommandOptions: []*autocliv1.RpcCommandOptions{ | ||
| { | ||
| RpcMethod: "Admins", | ||
| Use: "admins", | ||
| Short: "Query list of admins", | ||
| }, | ||
| { | ||
| RpcMethod: "ArchivedProposals", | ||
| Use: "archivedproposals", | ||
| Short: "Query archived proposals", | ||
| }, | ||
| { | ||
| RpcMethod: "ArchivedProposalsLegacy", | ||
| Use: "archivedproposalslegacy", | ||
| Short: "Query legacy archived proposals", | ||
| }, | ||
| }, | ||
| EnhanceCustomCommand: true, | ||
| }, | ||
| Tx: &autocliv1.ServiceCommandDescriptor{ | ||
| Service: "cosmos.adminmodule.adminmodule.Msg", | ||
| RpcCommandOptions: []*autocliv1.RpcCommandOptions{ | ||
| { | ||
| RpcMethod: "DeleteAdmin", | ||
| Use: "delete-admin [admin]", | ||
| Short: "Delete admin", | ||
| PositionalArgs: []*autocliv1.PositionalArgDescriptor{{ProtoField: "admin"}}, | ||
| }, | ||
| { | ||
| RpcMethod: "AddAdmin", | ||
| Use: "add-admin [admin]", | ||
| Short: "Add new admin", | ||
| PositionalArgs: []*autocliv1.PositionalArgDescriptor{{ProtoField: "admin"}}, | ||
| }, | ||
| { | ||
| RpcMethod: "SubmitProposalLegacy", | ||
| Skip: true, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also why do we skip it? |
||
| }, | ||
| }, | ||
| EnhanceCustomCommand: true, | ||
| }, | ||
| } | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there no command for a usual
SubmitProposalcommand?