BUG: don't try to be clever with cumulative retcodes to avoid retcode overflow - #97
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 637 637
=========================================
Hits 637 637
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
neutrinoceros
force-pushed
the
check_retcode_overflow
branch
from
February 10, 2022 17:51
0417495 to
15ff9fb
Compare
neutrinoceros
force-pushed
the
check_retcode_overflow
branch
from
February 10, 2022 17:54
15ff9fb to
97bb9f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just learned that retcodes overflow past 255 as shown here
So let's not be clever with retcodes, keep them simple and small.