Skip to content

BUG: don't try to be clever with cumulative retcodes to avoid retcode overflow - #97

Merged
neutrinoceros merged 1 commit into
mainfrom
check_retcode_overflow
Feb 10, 2022
Merged

BUG: don't try to be clever with cumulative retcodes to avoid retcode overflow#97
neutrinoceros merged 1 commit into
mainfrom
check_retcode_overflow

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Feb 10, 2022

Copy link
Copy Markdown
Owner

Just learned that retcodes overflow past 255 as shown here

$ echo "exit 256" > /tmp/t.sh
$ bash /tmp/t.sh
$ echo $?
0

So let's not be clever with retcodes, keep them simple and small.

@codecov

codecov Bot commented Feb 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #97 (97bb9f4) into main (5ccaa65) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          637       637           
=========================================
  Hits           637       637           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
inifix/__init__.py 100.00% <100.00%> (ø)
inifix/format.py 100.00% <100.00%> (ø)
inifix/validate.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ccaa65...97bb9f4. Read the comment docs.

@neutrinoceros neutrinoceros changed the title TST: add a test for retcode overflow BUG: don't try to be clever with cumulative retcodes to avoid retcode overflow Feb 10, 2022
@neutrinoceros
neutrinoceros merged commit de4318f into main Feb 10, 2022
@neutrinoceros
neutrinoceros deleted the check_retcode_overflow branch February 10, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant