Skip to content

BUG: fix a bug in str casting - #80

Merged
neutrinoceros merged 3 commits into
mainfrom
fix_string_delimiters
Nov 21, 2021
Merged

BUG: fix a bug in str casting#80
neutrinoceros merged 3 commits into
mainfrom
fix_string_delimiters

Conversation

@neutrinoceros

Copy link
Copy Markdown
Owner

goal: fix #79

@neutrinoceros neutrinoceros added the bug Something isn't working label Nov 21, 2021
@codecov

codecov Bot commented Nov 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #80 (32ecb41) into main (65d741a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   99.63%   99.64%           
=======================================
  Files          19       19           
  Lines         552      563   +11     
=======================================
+ Hits          550      561   +11     
  Misses          2        2           
Flag Coverage Δ
unittests 99.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
inifix/__init__.py 100.00% <100.00%> (ø)
inifix/iniconf.py 100.00% <100.00%> (ø)
tests/test_iniconf.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65d741a...32ecb41. Read the comment docs.

@neutrinoceros
neutrinoceros marked this pull request as ready for review November 21, 2021 13:23
@neutrinoceros neutrinoceros changed the title TST: add failing tests to cover string-casting bug BUG: Nov 21, 2021
@neutrinoceros neutrinoceros changed the title BUG: BUG: fix a bug in str casting Nov 21, 2021
@neutrinoceros
neutrinoceros merged commit 5c8ff4b into main Nov 21, 2021
@neutrinoceros
neutrinoceros deleted the fix_string_delimiters branch November 21, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: " and ' string delimiters are not parsed properly

1 participant