Skip to content

Conversation

@neutrinoceros
Copy link
Owner

@neutrinoceros neutrinoceros commented Dec 10, 2024

The underlying motivation is to get rid of the one warning I get from running pyright on main as

uv run --with pyright pyright src/gpgi
/Users/clm/dev/gpgi/src/gpgi/_data_types.py
  /Users/clm/dev/gpgi/src/gpgi/_data_types.py:130:52 - error: "_reference_field_name" is possibly unbound (reportPossiblyUnboundVariable)
1 error, 0 warnings, 0 informations 

Although the code is actually correct, it's understandable that a static analysis cannot prove it, and I want static analysis to prove correctness so let's rewrite it.
It's also arguably much nicer to remove 2 levels of indentation

@neutrinoceros neutrinoceros force-pushed the rfc/split_fieldmaps_validation branch from 1045b1c to 7ef95cf Compare December 10, 2024 18:37
@neutrinoceros neutrinoceros merged commit a6a4516 into main Dec 10, 2024
17 checks passed
@neutrinoceros neutrinoceros deleted the rfc/split_fieldmaps_validation branch December 10, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants