Skip to content

Conversation

@neutrinoceros
Copy link
Owner

Follow up to #240
So far I think test_concurrent_threading pass but test_concurrent_pool doesn't, and I have no idea why (yet).

@neutrinoceros neutrinoceros added the bug Something isn't working label Aug 10, 2024
@neutrinoceros neutrinoceros added this to the v2.0.0 milestone Aug 10, 2024
@neutrinoceros neutrinoceros changed the title BUG: fix thread safety for BoundaryRegistry.register BUG: fix thread safety for BoundaryRegistry.register Aug 10, 2024
@neutrinoceros neutrinoceros force-pushed the bug/boundary_registry_thread_safety branch from 223c92b to d892bd9 Compare August 10, 2024 13:56
@neutrinoceros
Copy link
Owner Author

turns out using threading.Thread or concurrent.futures.ThreadPoolExecutor has slightly different implications in terms of how exceptions get to surface, which is what I'm testing here, so I needed to rewrite the closure in two different ways for these tests, but the code itself was already working.

@neutrinoceros neutrinoceros force-pushed the bug/boundary_registry_thread_safety branch from d892bd9 to 4474eb2 Compare August 10, 2024 13:58
@neutrinoceros neutrinoceros marked this pull request as ready for review August 10, 2024 14:04
@neutrinoceros neutrinoceros merged commit a24a421 into main Aug 10, 2024
@neutrinoceros neutrinoceros deleted the bug/boundary_registry_thread_safety branch August 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants