Skip to content

RFC: drop misleading use of typing.Protocol #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neutrinoceros merged 1 commit into from
May 23, 2024
Merged

RFC: drop misleading use of typing.Protocol #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/gpgi/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from functools import cached_property, partial, reduce
from itertools import chain
from time import monotonic_ns
from typing import TYPE_CHECKING, Any, Literal, Protocol, cast
from typing import TYPE_CHECKING, Any, Literal, cast

import numpy as np

Expand Down Expand Up @@ -109,12 +109,12 @@ class DepositionMethod(enum.Enum):
}


class GeometricData(Protocol):
class GeometricData(ABC):
geometry: Geometry
axes: tuple[Name, ...]


class CoordinateData(Protocol):
class CoordinateData(ABC):
geometry: Geometry
axes: tuple[Name, ...]
coordinates: FieldMap
Expand Down