pin packaging to keep LegacyVersion support - #2706
Merged
Merged
Conversation
22.0 dropped LegacyVersion: pypa/packaging#407 This makes it so our branches can no longer be parsed as versions
pramodk
approved these changes
Feb 5, 2024
pramodk
enabled auto-merge (squash)
February 5, 2024 15:39
Merged
|
|
✔️ b95b892 -> Azure artifacts URL |
Collaborator
JCGoran
pushed a commit
that referenced
this pull request
May 27, 2025
As per pypa/setuptools#4483 (comment) setuptools version 71 and above is not compatible with packaging version 22 and below. In #2706 we pinned packaging to 21.3, but since merging #3370 this should no longer be required. This allows us to install a more recent version of setuptools (which is not used for building NEURON, but only for detecting the compiler version in binwrapper.py at run-time).
JCGoran
added a commit
that referenced
this pull request
May 30, 2025
As per pypa/setuptools#4483 (comment) setuptools version 71 and above is not compatible with packaging version 22 and below. In #2706 we pinned packaging to 21.3, but since merging #3370 this should no longer be required. This allows us to install a more recent version of setuptools (which is not used for building NEURON, but only for detecting the compiler version in binwrapper.py at run-time).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support was dropped in 22.0 (see https://packaging.pypa.io/en/latest/changelog.html). This breaks our readthedocs build for any branch that does not parse as a clean version number.