Skip to content

Conversation

fabio-innatera
Copy link
Collaborator

A number of fixes to make NIRTorch work with the new type inference in NIR: neuromorphs/NIR#153

If we want to make NIRTorch work asap with latest main of NIR (so without the type inference PR in NIR), we can merge just the first commit.

Copy link
Collaborator

@Jegp Jegp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, and I'm happy to merge. But the tests are somehow failing, cf. this screenshot from the CI pipeline
image

Could it be because it's using an old version of NIR? Maybe we can fix the version in the pyproject.toml if the issue persists?

@fabio-innatera
Copy link
Collaborator Author

fabio-innatera commented Jul 4, 2025

Could it be because it's using an old version of NIR? Maybe we can fix the version in the pyproject.toml if the issue persists?

Yes, that is exactly the problem, I think we could point it to the git branch in pyproject.toml.
Or we merge the other PR and point to latest main of NIR.

However, I just found another issue related to this: We install sinabs as part of the test dependencies,
which has nir==1.0.4 as a dependency. This downgrades nir from 1.0.5 (which has the type_check __init__ param) to 1.0.4 which does not have it. Which then breaks the test suite of NIRTorch, which depends on the parameter.

I have the same problem with talamo and norse, they need two different versions of NIR and NIRTorch, which makes testing quite painful. Basically testing is only possible by exchanging NIR files, two different versions of NIR cannot coexist in the same virtualenv.

Edit: Actually, the error you posted above comes from the issue with sinabs downgrading to 1.0.4.

@fabio-innatera fabio-innatera merged commit 3605543 into main Jul 7, 2025
15 checks passed
@Jegp Jegp deleted the nir-update branch July 7, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants