Added code to support recursion #34
Conversation
| @@ -105,20 +105,45 @@ def _construct_module_dict_recursive( | |||
| return owning_module | |||
|
|
|||
|
|
|||
|
|
|||
| def _find_input_nodes( | |||
There was a problem hiding this comment.
[Optional] Standardising documentation to include descriptions of all arguments would be beneficial as more open-source collaborations come in. Even if these functions are internal, they should have a description of each of the params + a docstring.
There was a problem hiding this comment.
A standardised format everywhere would accelerate reading and understanding and probably help a bit for any LLM assisted (vibe) coding
There was a problem hiding this comment.
Good point! When you say standardizing documentation, do you have a specific format in mind? Or something that we should adhere to that we're not?
There was a problem hiding this comment.
I just meant choosing and sticking to a consistent format so that e.g. autodoc from sphinx knows how to format the parameters / arguments nicely when displaying them and doctests that can be run in ci/cd to ensure the example in the docs always pass
|
There's still a bug with recurrent modules, hang on, I'll update the PR later.... |
|
Done! This should cover even complex use cases with recursive loops >= 2 modules. |
Adds support for recursion in modules by
torch.zeros(1).