Add schemaPath to ValidationMessage. #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphilipp64
reviewed
Apr 29, 2022
| @@ -113,17 +130,17 @@ public void setType(String type) { | |||
| this.type = type; | |||
| } | |||
|
|
|||
| public static ValidationMessage of(String type, ErrorMessageType errorMessageType, String at, String... arguments) { | |||
| public static ValidationMessage of(String type, ErrorMessageType errorMessageType, String at, String schemaPath, String... arguments) { | |||
There was a problem hiding this comment.
This is a breaking change, this should at least have been a bump of the minor version!
What's even worse, with the rest arguments parameter also being of the same type (String), any call to ValidationMessage.of that includes at least one argument silently shifts the first rest argument to become the schemaPath instead. No compiler warnings or anything to help detect this. Since this requires a manual search, I feel the changelog entry could have been a bit more detailed about this too.
I had some fun finding this out going from 1.0.68 → 1.0.69, I was lucky to have a test fail on it to detect the arguments shift…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#550