Skip to content
This repository was archived by the owner on Oct 10, 2022. It is now read-only.

chore(main): release 1.0.0 #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jul 5, 2022

🤖 I have created a release beep boop

1.0.0 (2022-07-11)

Features

  • bring in new changes from ZISI (aaa06bf)
  • extract implementation from ZISI (0922b9e)
  • make helper module configurable (212bd30)
  • make helperModule a predicate (32559c7)

Bug Fixes

  • deps: update babel monorepo to v7.18.8 (56255e4)
  • point entrypoint to index.js (b52dacf)

This PR was generated with Release Please. See documentation.

@Skn0tt
Copy link
Contributor

Skn0tt commented Jul 5, 2022

@danez I extracted out the in-source-configuration part of ZISI into this repository, so we can reuse it in edge-bundler. Could you give main a review? (using this PR as a stand-in)

@danez
Copy link

danez commented Jul 5, 2022

@Skn0tt
Copy link
Contributor

Skn0tt commented Jul 5, 2022

oh, maybe I forgot to pull before copying 😅 Thx, good that you caught this! I'll ping here again once I updated

@Skn0tt
Copy link
Contributor

Skn0tt commented Jul 5, 2022

Updated Codeowners/Fossa/labeler in 46d180c...0f23188

Stalebot was added by #2, so I guess we use it now 🤷

@Skn0tt
Copy link
Contributor

Skn0tt commented Jul 5, 2022

Brought in ZISI changes in aaa06bf :)

@github-actions github-actions bot force-pushed the release-please--branches--main--components--in-source-config branch from db5b59e to dea9528 Compare July 5, 2022 15:59
@github-actions github-actions bot requested a review from a team July 5, 2022 15:59
@danez
Copy link

danez commented Jul 5, 2022

The release-please job should use the token-generator, otherwise the workflows will not be triggered in PRs (like this one).
https://github.com/netlify/binary-info/blob/main/.github/workflows/release-please.yml#L10-L20

Also the release will not work:

Otherwise LGTM.

@danez
Copy link

danez commented Jul 5, 2022

And https://github.com/netlify/in-source-config/blob/main/package.json#L3 should probably be lifted before release :)

@Skn0tt
Copy link
Contributor

Skn0tt commented Jul 6, 2022

The release-please job should use the token-generator

Can you elaborate on that? I use release-please v3 in Skn0tt/datapact#157, and it works fine without token-generator.

NPM_TOKEN secret is not set yet, the same is true for the token generator secrets.

Asked in Slack for some admin to change that.

npm publish needs --access public

good point! done in 72c02f5

private: true needs to be lifted

done in 72c02f5

@github-actions github-actions bot force-pushed the release-please--branches--main--components--in-source-config branch from dea9528 to f4d867e Compare July 6, 2022 12:04
@danez
Copy link

danez commented Jul 6, 2022

Can you elaborate on that? I use release-please v3 in Skn0tt/datapact#157, and it works fine without token-generator.

Also in the linked PR it is not running the tests etc. This is because a workflow (in our cases release-please) cannot trigger other workflows through PRs, because otherwise, it could endup in an endless loop of triggering workflows. https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow
But if we use our own token like in the other repos it does work, because it is not github action triggering the workflow but the Github APP associated with the token.

In theory this is okay, because the release PR does not change anything so no need for tests and other stuff, but if we have required checks that need to be run like in your linked PR you won't be able to merge it ever.

@Skn0tt
Copy link
Contributor

Skn0tt commented Jul 6, 2022

Today I learned! That makes total sense. I'll update it.

@danez
Copy link

danez commented Jul 6, 2022

In my private repos I used a custom github token. https://github.com/reactjs/react-docgen/blob/main/.github/workflows/release-please.yml#L17
Only funny thing is then that the PRs are made in my name: reactjs/react-docgen#635 :)

@github-actions github-actions bot force-pushed the release-please--branches--main--components--in-source-config branch from f4d867e to 74b2eb3 Compare July 11, 2022 04:01
@github-actions github-actions bot force-pushed the release-please--branches--main--components--in-source-config branch from 74b2eb3 to 38fdf27 Compare July 11, 2022 04:01
@github-actions github-actions bot added the Stale label Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants