-
Notifications
You must be signed in to change notification settings - Fork 1
chore(main): release 1.0.0 #5
base: main
Are you sure you want to change the base?
chore(main): release 1.0.0 #5
Conversation
|
oh, maybe I forgot to pull before copying 😅 Thx, good that you caught this! I'll ping here again once I updated |
Updated Codeowners/Fossa/labeler in 46d180c...0f23188 Stalebot was added by #2, so I guess we use it now 🤷 |
Brought in ZISI changes in aaa06bf :) |
db5b59e
to
dea9528
Compare
The release-please job should use the token-generator, otherwise the workflows will not be triggered in PRs (like this one). Also the release will not work:
Otherwise LGTM. |
And https://github.com/netlify/in-source-config/blob/main/package.json#L3 should probably be lifted before release :) |
Can you elaborate on that? I use release-please v3 in Skn0tt/datapact#157, and it works fine without token-generator.
Asked in Slack for some admin to change that.
good point! done in 72c02f5
done in 72c02f5 |
dea9528
to
f4d867e
Compare
Also in the linked PR it is not running the tests etc. This is because a workflow (in our cases release-please) cannot trigger other workflows through PRs, because otherwise, it could endup in an endless loop of triggering workflows. https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow In theory this is okay, because the release PR does not change anything so no need for tests and other stuff, but if we have required checks that need to be run like in your linked PR you won't be able to merge it ever. |
Today I learned! That makes total sense. I'll update it. |
In my private repos I used a custom github token. https://github.com/reactjs/react-docgen/blob/main/.github/workflows/release-please.yml#L17 |
f4d867e
to
74b2eb3
Compare
74b2eb3
to
38fdf27
Compare
🤖 I have created a release beep boop
1.0.0 (2022-07-11)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.