-
Notifications
You must be signed in to change notification settings - Fork 414
Description
Is your feature request related to a problem? Please describe.
When running neflity deploy --trigger
, along with --message "Some String"
there is no deploy message registered in the dashboard.
Describe the solution you'd like
I'd like the --message flag to be available when using the --trigger flag and for the message to show up on the Deploy list page of the Netlify Dashboard (and potentially directly in a deploy log, if that's currently the default for deploy logs; otherwise that would be a separate request, which I'm not making.)
Describe alternatives you've considered
None that I'm aware of.
Additional context
You can see messages show up for Github (push) deploys but, when using the CLI with the --trigger and --message flags together, the log is without a deploy message:
The trigger flag code:
Lines 426 to 428 in 0d2708e
if (flags.trigger) { | |
return triggerDeploy({ api, siteId, siteData }) | |
} |
Lines 31 to 44 in 0d2708e
const triggerDeploy = async ({ api, siteData, siteId }) => { | |
try { | |
const siteBuild = await api.createSiteBuild({ siteId }) | |
log( | |
`${NETLIFYDEV} A new deployment was triggered successfully. Visit https://app.netlify.com/sites/${siteData.name}/deploys/${siteBuild.deploy_id} to see the logs.`, | |
) | |
} catch (error_) { | |
if (error_.status === 404) { | |
error('Site not found. Please rerun "netlify link" and make sure that your site has CI configured.') | |
} else { | |
error(error_.message) | |
} | |
} | |
} |
Can you submit a pull request?
Yes/No...Maybe? I'm more than happy to contribute but, not sure of myself. I'll read the guidelines, either way.
Pull requests are welcome! If you would like to help us add this feature, please check our
contributions guidelines.