Skip to content

Add ignoreElements input to API #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ inputs:
- name: ignoreDirectories
default: []
description: Array of directories whose pages the plugin should ignore when checking for a11y issues. Defaults to [].
- name: ignoreElements
description: A CSS selector to ignore elements when testing. Accepts multiple comma-separated selectors.
- name: wcagLevel
default: 'WCAG2AA'
description: The level of WCAG 2.1 against which to check site pages. Defaults to 'WCAGAA'; can also be 'WCAGA' or 'WCAGAAA'.
22 changes: 15 additions & 7 deletions src/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,33 @@ const PA11Y_DEFAULT_WCAG_LEVEL = 'WCAG2AA'
const PA11Y_RUNNERS = ['axe']
const PA11Y_USER_AGENT = 'netlify-plugin-a11y'

const getConfiguration = ({
const getConfiguration = async ({
constants: { PUBLISH_DIR },
inputs: { checkPaths, ignoreDirectories, failWithIssues, wcagLevel },
inputs: { checkPaths, ignoreDirectories, ignoreElements, failWithIssues, wcagLevel },
}) => {
return {
publishDir: PUBLISH_DIR || process.env.PUBLISH_DIR,
checkPaths: checkPaths || DEFAULT_CHECK_PATHS,
ignoreDirectories: ignoreDirectories || DEFAULT_IGNORE_DIRECTORIES,
failWithIssues: failWithIssues !== undefined ? failWithIssues : DEFAULT_FAIL_WITH_ISSUES,
wcagLevel: wcagLevel || PA11Y_DEFAULT_WCAG_LEVEL,
ignoreDirectories: ignoreDirectories || DEFAULT_IGNORE_DIRECTORIES,
pa11yOpts: await getPa11yOpts({ hideElements: ignoreElements, standard: wcagLevel || PA11Y_DEFAULT_WCAG_LEVEL }),
publishDir: PUBLISH_DIR || process.env.PUBLISH_DIR,
}
}

const getPa11yOpts = async (wcagLevel) => {
/**
* Generates the options object used to configure Pa11y.
* @param {Object} pa11yInputs
* @param {String} [pa11yInputs.hideElements]
* @param {'WCAG2A' | 'WCAG2AA' | 'WCAG2AAA'} [pa11yInputs.standard]
* @returns
*/
const getPa11yOpts = async ({ hideElements, standard }) => {
return {
browser: await puppeteer.launch({ ignoreHTTPSErrors: true }),
hideElements,
runners: PA11Y_RUNNERS,
userAgent: PA11Y_USER_AGENT,
standard: wcagLevel || PA11Y_DEFAULT_WCAG_LEVEL,
standard,
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const pico = require('picocolors')
module.exports = {
async onPostBuild({ constants, inputs, utils: { build } }) {
try {
const { publishDir, checkPaths, ignoreDirectories, wcagLevel, failWithIssues } = getConfiguration({
const { publishDir, checkPaths, ignoreDirectories, failWithIssues, pa11yOpts } = await getConfiguration({
constants,
inputs,
})
Expand All @@ -23,7 +23,7 @@ module.exports = {
build,
htmlFilePaths,
publishDir,
wcagLevel,
pa11yOpts,
})
const reportSummary =
`${issueCount === 0 ? 'No' : issueCount} accessibility issues found!` +
Expand Down
4 changes: 1 addition & 3 deletions src/pluginCore.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,14 @@ const { extname, join } = require('path')
const { isDirectory, isFile } = require('path-type')
const { results: cliReporter } = require('./reporter')
const readdirp = require('readdirp')
const { getPa11yOpts } = require('./config')
const { StaticServer, SERVER_ADDRESS } = require('./server')

const EMPTY_ARRAY = []
const ASTERISK = '*'
const HTML_EXT = '.html'
const GLOB_HTML = '*.html'

exports.runPa11y = async function ({ build, htmlFilePaths, publishDir, wcagLevel }) {
const pa11yOpts = await getPa11yOpts(wcagLevel)
exports.runPa11y = async function ({ build, htmlFilePaths, pa11yOpts, publishDir }) {
let issueCount = 0

const staticServer = new StaticServer(publishDir).listen()
Expand Down
4 changes: 3 additions & 1 deletion tests/runPa11y/this.test.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
const path = require('path')
const { getPa11yOpts } = require('../../src/config')
const filePath = path.relative(process.cwd(), path.join(__dirname, 'publishDir/index.html'))

// actual test
const pluginCore = require('../../src/pluginCore')
test('runPa11y works', async () => {
const results = await pluginCore.runPa11y({
htmlFilePaths: [filePath],
build: { failBuild() {} },
htmlFilePaths: [filePath],
pa11yOpts: await getPa11yOpts({}),
})
expect(results).toMatchSnapshot()
})