Fix HTML crawling #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swyxio
approved these changes
May 4, 2020
23 tasks
|
You're right: fixed in cbb9597. |
swyxio
reviewed
May 4, 2020
plugin/pluginCore.js
Outdated
| } | ||
|
|
||
| if (!(await isFile(fileAndDirPath))) { | ||
| build.failBuild(`Input "checkPaths" does not exist: ${fileAndDirPath}`) |
There was a problem hiding this comment.
wait.. why fail build? should we just warn instead?
also i think the wording can be better.. maybe Warning: Folder ${fileAndDirPath} was provided in "checkPaths", but does not exist - it either indicates something went wrong with your build, or you can simply delete this folder from your "checkPaths" in netlify.toml
|
v 0.0.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19.
HTML crawling fails when one of the paths passed as
checkPathsdoes not exist.This PR also makes the crawling happen in parallel for all
checkPaths(instead of serially) and replace custom crawling by thereaddirplibrary.