Skip to content

Monorepo fix #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Monorepo fix #269

merged 2 commits into from
Aug 24, 2020

Conversation

daniloraisi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

When working on a Monorepo Function files are generated per app basis, but nest build will generate everything into dist folder. So we have problems publishing them.

Issue Number: #265

What is the new behavior?

Now we are able to install Azure Functions on a project basis, but have only one entry point at root directory.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Danilo Tenorio Raisi added 2 commits May 28, 2020 19:26
Cleared debug code and fixed main NestJS entry point
Copy link
Contributor

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @daniloraisi, I think this is a better solution then I've implemented it. The only confusion I have is with the folder per project in the root that contains the "azure setup". However, I don't see any other solution atm if you want to publish azure func. from the root directory.

@kamilmysliwiec could you do a review? As I said above I think this is a better a friendlier solution because you do everything from the root dir.

@kamilmysliwiec
Copy link
Member

I'll look into this as soon as possible. Thanks for your contribution @daniloraisi!

@kamilmysliwiec kamilmysliwiec added the enhancement New feature or request label Jun 5, 2020
@daniloraisi
Copy link
Contributor Author

@Jefiozie It's a little bit confusing, but the reason to do that is that Functions will look up for a host.json file at the directory you're running the command. With this in mind, it look up for functions.json files in each subdirectory, but only 1 depth.

@daniloraisi
Copy link
Contributor Author

Hi @kamilmysliwiec, some news about this?

@kamilmysliwiec kamilmysliwiec merged commit f60eeb6 into nestjs:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants