Skip to content

fix: Ensure integration test required checks fail on chunk failures#5241

Merged
chenyukang merged 1 commit into
nervosnetwork:developfrom
Officeyutong:fix-ci-1
Jun 17, 2026
Merged

fix: Ensure integration test required checks fail on chunk failures#5241
chenyukang merged 1 commit into
nervosnetwork:developfrom
Officeyutong:fix-ci-1

Conversation

@Officeyutong

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
The integration-test workflows run the real tests in matrix jobs named Run tests (chunk N), then keep the historical required-check names as final aggregate jobs:

  • ci_integration_tests_ubuntu
  • ci_integration_tests_macos
  • ci_integration_tests_windows

Those aggregate jobs depended on the matrix test job but used the default success condition. If any matrix chunk failed, the aggregate job was skipped. GitHub Actions reports skipped jobs as successful, even for required checks, so branch protection relying on the historical check names could allow a PR to merge despite failed integration-test chunks.

What is changed and how it works?

Proposal: xxx

What's Changed:

Run the aggregate required-check jobs with always() and explicitly inspect needs.test.result.

If the matrix test job result is not success, the aggregate job now exits with failure. This preserves the old required-check names while ensuring they accurately reflect the real integration-test result.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
  • Breaking backward compatibility

@Officeyutong Officeyutong requested a review from a team as a code owner June 16, 2026 11:27
@Officeyutong Officeyutong requested review from doitian and removed request for a team June 16, 2026 11:27
@chenyukang chenyukang added this pull request to the merge queue Jun 17, 2026
@chenyukang chenyukang removed this pull request from the merge queue due to a manual request Jun 17, 2026
@chenyukang chenyukang merged commit 0b5556f into nervosnetwork:develop Jun 17, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants