fix: Ensure integration test required checks fail on chunk failures#5241
Merged
Conversation
doitian
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
The integration-test workflows run the real tests in matrix jobs named
Run tests (chunk N), then keep the historical required-check names as final aggregate jobs:ci_integration_tests_ubuntuci_integration_tests_macosci_integration_tests_windowsThose aggregate jobs depended on the matrix
testjob but used the default success condition. If any matrix chunk failed, the aggregate job was skipped. GitHub Actions reports skipped jobs as successful, even for required checks, so branch protection relying on the historical check names could allow a PR to merge despite failed integration-test chunks.What is changed and how it works?
Proposal: xxx
What's Changed:
Run the aggregate required-check jobs with
always()and explicitly inspectneeds.test.result.If the matrix test job result is not
success, the aggregate job now exits with failure. This preserves the old required-check names while ensuring they accurately reflect the real integration-test result.Related changes
owner/repo:Check List
Tests
Side effects