Skip to content

Commit 0b5556f

Browse files
authored
fix: Ensure integration test required checks fail on chunk failures (#5241)
1 parent ee18fd4 commit 0b5556f

3 files changed

Lines changed: 24 additions & 9 deletions

File tree

.github/workflows/ci_integration_tests_macos.yaml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,13 @@ jobs:
179179
ci_integration_tests_macos:
180180
name: ci_integration_tests_macos
181181
needs: test
182-
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository
182+
if: ${{ always() && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository) }}
183183
runs-on: ubuntu-latest
184184
steps:
185-
- name: All tests passed
186-
run: echo "All test chunks completed successfully"
185+
- name: Check test chunks result
186+
run: |
187+
if [ "${{ needs.test.result }}" != "success" ]; then
188+
echo "Integration test chunks did not complete successfully: ${{ needs.test.result }}"
189+
exit 1
190+
fi
191+
echo "All test chunks completed successfully"

.github/workflows/ci_integration_tests_ubuntu.yaml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,11 +185,16 @@ jobs:
185185
ci_integration_tests_ubuntu:
186186
name: ci_integration_tests_ubuntu
187187
needs: test
188-
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository
188+
if: ${{ always() && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository) }}
189189
runs-on: ubuntu-latest
190190
steps:
191-
- name: All tests passed
192-
run: echo "All test chunks completed successfully"
191+
- name: Check test chunks result
192+
run: |
193+
if [ "${{ needs.test.result }}" != "success" ]; then
194+
echo "Integration test chunks did not complete successfully: ${{ needs.test.result }}"
195+
exit 1
196+
fi
197+
echo "All test chunks completed successfully"
193198
194199
ci_cli_bats_test:
195200
name: ci_cli_bats_test

.github/workflows/ci_integration_tests_windows.yaml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,13 @@ jobs:
181181
ci_integration_tests_windows:
182182
name: ci_integration_tests_windows
183183
needs: test
184-
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository
184+
if: ${{ always() && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository) }}
185185
runs-on: ubuntu-latest
186186
steps:
187-
- name: All tests passed
188-
run: echo "All test chunks completed successfully"
187+
- name: Check test chunks result
188+
run: |
189+
if [ "${{ needs.test.result }}" != "success" ]; then
190+
echo "Integration test chunks did not complete successfully: ${{ needs.test.result }}"
191+
exit 1
192+
fi
193+
echo "All test chunks completed successfully"

0 commit comments

Comments
 (0)