Rejection sample mask for patch pixel sampler #3457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+@akristoffersen for review please |
| if isinstance(mask, Tensor) and not self.config.ignore_mask: | ||
| sub_bs = batch_size // (self.config.patch_size**2) | ||
| half_patch_size = int(self.config.patch_size / 2) | ||
| m = erode_mask(mask.permute(0, 3, 1, 2).float(), pixel_radius=half_patch_size) |
There was a problem hiding this comment.
This is making me realize, instead of eroding, it might be better to just rejection sample patches across the image, rejecting if the whole patch isn't within the mask. Could be faster if the masks are large and the patches are small.
There was a problem hiding this comment.
That is probably true. I didn't really look into the functionality of the PatchPixelSampler yet but can find some time to do so later this week.
There was a problem hiding this comment.
Gotcha. That could also go in a separate PR for sure.
akristoffersen
approved these changes
Oct 1, 2024
nepfaff
force-pushed
the
rejection_sample_mask_for_patch_pixel_sampler
branch
from
0f8bfb1 to
688ba70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3452 for context.
NOTE: This must be merged after #3452. I wanted to specify the #3452 branch as the base branch but somehow couldn't find it in the GitHub UI...