Skip to content

Check postgresql ALPN value for direct SSL connections #12783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Check postgresql ALPN value for direct SSL connections #12783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bd2486
Check postgresql ALPN value for direct SSL connections
jawj Jul 30, 2025
bfb86b2
Briefer ALPN error message
jawj Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion proxy/src/pglb/handshake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,13 @@ pub(crate) async fn handshake<S: AsyncRead + AsyncWrite + Unpin + Send>(

// check the ALPN, if exists, as required.
match conn_info.alpn_protocol() {
None | Some(PG_ALPN_PROTOCOL) => {}
None => {
if direct.is_some() {
warn!("missing ALPN");
return Err(HandshakeError::ProtocolViolation);
}
}
Some(PG_ALPN_PROTOCOL) => {}
Some(other) => {
let alpn = String::from_utf8_lossy(other);
warn!(%alpn, "unexpected ALPN");
Expand Down
Loading