Skip to content

Make internal config parsing helper functions private #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

Make internal config parsing helper functions private #1186

merged 1 commit into from
May 20, 2025
+117 −121

Conversation

robsdedude
Copy link
Member

Make undocumented internal helper private:

  • neo4j.api.check_access_mode
  • neo4j.api.parse_neo4j_uri
  • neo4j.api.parse_routing_context

MaxAake
MaxAake approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✅

@robsdedude robsdedude merged commit 185f24f into neo4j:6.x May 20, 2025
20 checks passed
@robsdedude robsdedude deleted the remove-config-parser-helpers branch May 20, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxAake MaxAake MaxAake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsdedude @MaxAake