Skip to content

Make Summary.summary_notifications a tuple #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

Make Summary.summary_notifications a tuple #1185

merged 2 commits into from
May 19, 2025

Conversation

robsdedude
Copy link
Member

Make Summary.summary_notifications a tuple instead of a list and type it with Sequence to signify that it should be treated as immutable.

MaxAake
MaxAake approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✅

@robsdedude robsdedude enabled auto-merge (squash) May 19, 2025 17:06
@robsdedude robsdedude merged commit ce4ec99 into neo4j:6.x May 19, 2025
20 checks passed
@robsdedude robsdedude deleted the summary-notifications-as-sequence branch May 19, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxAake MaxAake MaxAake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsdedude @MaxAake