Skip to content

Remove internal constants #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

Remove internal constants #1176

merged 2 commits into from
May 16, 2025

Conversation

robsdedude
Copy link
Member

Make undocumented internal constants private:

  • neo4j.api
    • DRIVER_BOLT
    • DRIVER_NEO4J
    • SECURITY_TYPE_NOT_SECURE
    • SECURITY_TYPE_SECURE
    • SECURITY_TYPE_SELF_SIGNED_CERTIFICATE
  • neo4j.exceptions
    • CLASSIFICATION_CLIENT
    • CLASSIFICATION_DATABASE
    • CLASSIFICATION_TRANSIENT
    • ERROR_REWRITE_MAP
    • client_errors
    • transient_errors

AndyHeap-NeoTech
AndyHeap-NeoTech approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robsdedude robsdedude enabled auto-merge (squash) May 16, 2025 14:33
@robsdedude robsdedude merged commit fde060c into neo4j:6.x May 16, 2025
20 checks passed
@robsdedude robsdedude deleted the remove-internal-constants branch May 16, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyHeap-NeoTech AndyHeap-NeoTech AndyHeap-NeoTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsdedude @AndyHeap-NeoTech