Skip to content

New ConnectionAcquisitionTimeoutError instead of ClientError #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

robsdedude
Copy link
Member

Raise a new ConnectionAcquisitionTimeoutError (subclass of DriverError) instead of ClientError (subclass of Neo4jError) when the connection acquisition timeout is exceeded.

This improves the differentiation between DriverError for client-side errors and Neo4jError for server-side errors.

Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robsdedude robsdedude force-pushed the errors/driver-error-on-connection-acquitision-timeout branch from 13ba48a to 8a1ab22 Compare May 15, 2025 09:59
@robsdedude robsdedude enabled auto-merge (squash) May 15, 2025 11:52
@robsdedude robsdedude merged commit 7154681 into neo4j:6.x May 15, 2025
20 checks passed
@robsdedude robsdedude deleted the errors/driver-error-on-connection-acquitision-timeout branch May 15, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants