Replace unclear fromStandardDate() #1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
approved these changes
May 28, 2025
There was a problem hiding this comment.
Optional: I think it might be very much worthwhile to run these tests for different time zones/locales. In particular the ones that are far off of UTC (and maybe also UTC itself).
https://stackoverflow.com/questions/8083410/how-can-i-set-the-default-timezone-in-node-js
robsdedude
reviewed
May 28, 2025
MaxAake
force-pushed
the
solve-timezone-hell
branch
from
133bb98 to
721277b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Neo4j.DatefunctionsfromStandardDate()andtoStandardDate()are not inverse functions of each other, asfromStandardDate()takes the date that the StandardDate would correspond to in local time, andtoStandardDate()creates a Date set at Midnight UTC.This PR deprecates the old
fromStandardDate()and replaces it with a drop-in replacementfromStandardDateLocal()which functions the same andfromStandardDateUTC()which takes the date as interpreted in UTC.