Skip to content

Remove Severity From Notification #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Remove Severity From Notification #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1440095
remove notification severity
MaxAake May 23, 2025
d245475
fix some tests for removed severity
MaxAake May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions packages/core/src/notification.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ class Notification {
code: string
title: string
description: string
severity: string
position: NotificationPosition | {}
severityLevel: NotificationSeverityLevel
category: NotificationCategory
Expand Down Expand Up @@ -135,16 +134,6 @@ class Notification {
* @public
*/
this.description = notification.description
/**
* The raw severity
*
* Use {@link Notification#rawSeverityLevel} for the raw value or {@link Notification#severityLevel} for an enumerated value.
*
* @type {string}
* @public
* @deprecated This property will be removed in 6.0.
*/
this.severity = notification.severity
/**
* The position which the notification had occur.
*
Expand Down
11 changes: 0 additions & 11 deletions packages/neo4j-driver-deno/lib/core/notification.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/neo4j-driver/test/rx/summary.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ describe('#integration-rx summary', () => {
)
expect(summary.notifications[0].title).toContain('label')
expect(summary.notifications[0].description).toContain('label')
expect(summary.notifications[0].severity).toBe('WARNING')
expect(summary.notifications[0].rawSeverityLevel).toBe('WARNING')
}

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/neo4j-driver/test/summary.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ describe('#integration result summary', () => {
expect(notification.code).toBeDefined()
expect(notification.title).toBeDefined()
expect(notification.description).toBeDefined()
expect(notification.severity).toBeDefined()
expect(notification.rawSeverityLevel).toBeDefined()
expect(notification.position).toBeDefined()

done()
Expand Down
1 change: 0 additions & 1 deletion packages/neo4j-driver/test/types/result-summary.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ const notification: Notification = notifications[0]
const code: string = notification.code
const title: string = notification.title
const description: string = notification.description
const severity: string = notification.severity
const position1: NotificationPosition | {} = notification.position
const position2: NotificationPosition = notification.position as NotificationPosition

Expand Down