Transaction#commit and Transaction#rollback
#622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
force-pushed
the
4.0-commit-rollback
branch
from
a5cf951 to
324c166
Compare
Changed the behaviour of `AsyncTransaction#commitAsync` and `AsyncTransaction#rollbackAsync` to throw error when committing/rolling back second time. A transaction can be allowed to commit or rollback once, but closed multiple times. This bring the behaviour of commit and rollback the same as 4.0 core API, as well as all other language drivers.
zhenlineo
force-pushed
the
4.0-commit-rollback
branch
from
324c166 to
83d57d7
Compare
ali-ince
approved these changes
Aug 26, 2019
| @@ -130,7 +104,7 @@ else if ( state != State.COMMITTED && state != State.ROLLED_BACK ) | |||
| { | |||
| if ( state == State.COMMITTED ) | |||
| { | |||
| return completedWithNull(); | |||
| return failedFuture( new ClientException( "Can't commit, transaction has been committed" ) ); | |||
There was a problem hiding this comment.
I'm definitely not an English guru, but I would find Can't commit, because transaction has already been committed. more descriptive. And it would be nice if we could standardise the error messages like using always Can't or Cannot in the same context.
| @@ -152,7 +126,7 @@ else if ( state == State.ROLLED_BACK ) | |||
| } | |||
| else if ( state == State.ROLLED_BACK ) | |||
| { | |||
| return completedWithNull(); | |||
| return failedFuture( new ClientException( "Can't rollback, transaction has been rolled back" ) ); | |||
There was a problem hiding this comment.
Same here, and also the following (unchanged) messages with regards to standardisation,
zhenlineo
force-pushed
the
4.0-commit-rollback
branch
from
1b7ebd7 to
83d57d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
Transaction#successandTransaction#failureChanged the behaviour of
AsyncTransaction#commitAsyncandAsyncTransaction#rollbackAsyncto throw error when committing/rolling back second time.A transaction can be allowed to commit or rollback once, but closed multiple times.
This bring the behaviour of commit and rollback the same as 4.0 core API, as well as all other language drivers.