Fix the wrong chunk header size due to clear the whole buffer by mistake #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The situation where the issue arises:
When
IN_CHUNK
,The problem is that there could be more bytes that do not belong to readable bytes left in the buffer, such as (part of) next chunk header!!
So instead of buffer.clear, use buffer.compact would solve this issue.
Tests should be needed to accept this PR.