Short-circuit retries on context timeout #666
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check explicitly for context completion in State.Continue to prevent unnecessary work that will inevitably fail. This also fixes a bug where ExecuteQuery will loop without sleeping until a condition is hit (like MaxTransactionRetryTime or MaxDeadConnections) because the error handling sets skipSleep = true.
zolstein
commented
Sep 3, 2025
Comment on lines
+189
to
+192
| ctx := context.Background() | ||
| ctx, cancel := context.WithTimeout(ctx, 0) | ||
| defer cancel() | ||
| <-ctx.Done() |
There was a problem hiding this comment.
This unusual method of cancelling the context causes it ctx.Err() to return "deadline exceeded", which represents a worst-case scenario - without the change to Continue, it will process the error as retryable and loop until it hits the MaxDeadConnections limit. By comparison, just cancelling the context the usual way will fail after one attempt, because the "context cancelled" error isn't retryable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check explicitly for context completion in State.Continue to prevent unnecessary work that will inevitably fail.
This also fixes a bug where ExecuteQuery will loop without sleeping until a condition is hit (like MaxTransactionRetryTime or MaxDeadConnections) because the error handling sets skipSleep = true.