Log entry error resolved #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveshkumar1988
requested changes
Jan 8, 2025
karanchellani
approved these changes
Jan 8, 2025
kaustubh-darekar
added a commit
that referenced
this pull request
Jan 28, 2025
* Nova models trial. * google.protobuf.json_format.ParseError resolved * removing mistakenly added file * removed tasks from logger struct
kartikpersistent
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Nova models trial. * google.protobuf.json_format.ParseError resolved * removing mistakenly added file * removed tasks from logger struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logger.log_struct() was giving error due to tasks passed as set.
google.protobuf.json_format.ParseError: Value {'enable_communities', 'materialize_entity_similarities', 'enable_hybrid_search_and_fulltext_search_in_bloom', 'materialize_text_chunk_similarities'} has unexpected type <class 'set'> at LogEntry.jsonPayload.message.tasks
resolved this error by changing tasks to list