Driver NotificationFilter config #533

thelonelyvulpes · 2022-10-24T15:13:20Z

Add tests for:

Driver notification filter config. hello message bolt 5.2+
Session notification filter config. begin and run message on bolt 5.2+
severity & category being populated on notifications

tests/stub/session_notification_filters/test_driver_notification_filters.py

nutkit/protocol/feature.py

nutkit/protocol/requests.py

Co-authored-by: Robsdedude <[email protected]>

…ure/notifications

tests/stub/notification_filters/notification_filters_base.py

Co-authored-by: Robsdedude <[email protected]>

`super()` is only necessary when you explicitly want to avoid accessing the child-class.

robsdedude

Works like a charm 🌟

The only thing that could be improved is documenting the notification structure. So maybe instead of having _reduce_notifications, we add another class like SummaryNotification to the protocol. See nutkit.protocol.responses.SummaryCounters for inspiration.

Co-authored-by: Dmitriy Tverdiakov <[email protected]>

neo-technology/drivers-adr#64

Iff the driver is configured with a (non-static) auth token manager, it should retry transactions on token expired errors.

tests/stub/notifications_config/notifications_base.py

Signed-off-by: Florent Biville <[email protected]>

tests/stub/notifications_config/scripts/notifications_config_override_session_begin.script

tests/stub/notifications_config/scripts/notifications_config_override_session_run.script

tests/stub/notifications_config/notifications_base.py

Co-authored-by: Dmitriy Tverdiakov <[email protected]>

bigmontz

🔔

RichardIrons-neo4j

Just a small thing about constants

thelonelyvulpes added 3 commits October 24, 2022 15:52

basic setup.

de8a76f

undo commithook change

6338f05

full suite for driver config, undo validation for mapping

8cddfa2

thelonelyvulpes marked this pull request as ready for review October 24, 2022 16:14

thelonelyvulpes changed the title ~~Notification filters.~~ Driver NotificationFilter config Oct 24, 2022

thelonelyvulpes added 5 commits October 24, 2022 17:17

driver feature

aec9272

add multi-filter config

fd21236

formatting for picky-parens

e463879

session configs

2c13c5d

move

b86aabc

robsdedude reviewed Oct 25, 2022

View reviewed changes

tests/stub/session_notification_filters/test_driver_notification_filters.py Outdated Show resolved Hide resolved

thelonelyvulpes added 4 commits October 25, 2022 19:10

dedupes

7b2afbe

rename to make it look nicer

d3e281e

mapping tests

de188d5

add tx func test

2d13713

robsdedude reviewed Oct 28, 2022

View reviewed changes

nutkit/protocol/feature.py Outdated Show resolved Hide resolved

robsdedude reviewed Oct 28, 2022

View reviewed changes

nutkit/protocol/requests.py Outdated Show resolved Hide resolved

thelonelyvulpes and others added 4 commits October 28, 2022 09:35

Update nutkit/protocol/feature.py

e157f61

Co-authored-by: Robsdedude <[email protected]>

always serialize notification filters

f7e8e77

Merge remote-tracking branch 'origin/feature/notifications' into feat…

db71062

…ure/notifications

Feature:API:Driver:NotificationFilters

129eaf6

robsdedude reviewed Oct 28, 2022

View reviewed changes

tests/stub/notification_filters/notification_filters_base.py Outdated Show resolved Hide resolved

robsdedude and others added 4 commits October 28, 2022 10:53

Stubscript: add bolt alias 5 == 5.0

52e8173

Update tests/stub/notification_filters/notification_filters_base.py

002028c

Co-authored-by: Robsdedude <[email protected]>

Don't assert notifications order

0e251e7

Replace some super calls

478a0d2

`super()` is only necessary when you explicitly want to avoid accessing the child-class.

robsdedude approved these changes Oct 28, 2022

View reviewed changes

robsdedude mentioned this pull request Oct 28, 2022

Notifications api neo4j/neo4j-python-driver#847

Merged

robsdedude added 2 commits October 31, 2022 14:27

New HELLO message structure in Bolt 5.1

a3c1e32

Add tests for new HELLO structure in BOLT 5.1

32bbc47

robsdedude and others added 15 commits February 8, 2023 16:31

Fix types.Feature.OPT_MINIMAL_RESETS assertion

84db82e

Move routing from LOGON to HELLO in kerberos test

d75a7a9

out of scope optimization

76d8786

re-auth: adopt auth token provider API

c349e71

Add missing feature guard

6e37294

Co-authored-by: Dmitriy Tverdiakov <[email protected]>

Add error code for Java driver

ad56dba

Co-authored-by: Dmitriy Tverdiakov <[email protected]>

Allow optional routing to be null

4f8fa2e

Put user switching polyfill on hold

31f0c3f

neo-technology/drivers-adr#64

Put auth token manager behind feature flag

23a027c

Improve Stubscript docs

0b0ee94

Add tests for retryable token expired error

5d39f52

Iff the driver is configured with a (non-static) auth token manager, it should retry transactions on token expired errors.

Add basic Bolt 5.1 tests

5f3b07f

Merge branch 're-auth' into feature/notifications

f7178b7

add test empty array

b9b21c0

Remove all re-auth tests; leave only basic bolt 5.2 tests

bafa3ef

injectives reviewed Mar 13, 2023

View reviewed changes

tests/stub/notifications_config/notifications_base.py Show resolved Hide resolved

Fix summary tests to include new notification properties

b8f0ba2

Signed-off-by: Florent Biville <[email protected]>

injectives reviewed Mar 15, 2023

View reviewed changes

tests/stub/notifications_config/scripts/notifications_config_override_session_begin.script Outdated Show resolved Hide resolved

injectives reviewed Mar 15, 2023

View reviewed changes

tests/stub/notifications_config/scripts/notifications_config_override_session_run.script Outdated Show resolved Hide resolved

injectives reviewed Mar 15, 2023

View reviewed changes

tests/stub/notifications_config/notifications_base.py Outdated Show resolved Hide resolved

robsdedude and others added 2 commits March 15, 2023 09:42

Check disabled categories regardless of order

71babad

Co-authored-by: Dmitriy Tverdiakov <[email protected]>

Merge branch '5.0' into feature/notifications

83835aa

fbiville approved these changes Mar 15, 2023

View reviewed changes

thelonelyvulpes added 2 commits March 15, 2023 17:47

support pre-notifications change

da86f42

replace try with if has new notifications config

89ccf83

bigmontz approved these changes Mar 16, 2023

View reviewed changes

fix for python

9332c18

thelonelyvulpes merged commit 4512d8a into neo4j-drivers:5.0 Mar 16, 2023

thelonelyvulpes deleted the feature/notifications branch March 16, 2023 17:36

RichardIrons-neo4j reviewed Mar 27, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Driver NotificationFilter config #533

Driver NotificationFilter config #533

Uh oh!

thelonelyvulpes commented Oct 24, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robsdedude left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bigmontz left a comment

Uh oh!

RichardIrons-neo4j left a comment

Uh oh!

Uh oh!

Driver NotificationFilter config #533

Driver NotificationFilter config #533

Uh oh!

Conversation

thelonelyvulpes commented Oct 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robsdedude left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bigmontz left a comment

Choose a reason for hiding this comment

Uh oh!

RichardIrons-neo4j left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thelonelyvulpes commented Oct 24, 2022 •

edited

Loading

robsdedude left a comment •

edited

Loading