Introduce Driver.execute_query
#531
Conversation
|
|
||
| if bookmark_manager is None: | ||
| config["bookmarkManagerId"] = -1 | ||
| elif bookmark_manager is not Ellipsis: |
| C: BEGIN {"[db]": "*"} | ||
| S: SUCCESS {} | ||
| {{ | ||
| C: RUN "CREATE (p:Person{name:$name}) RETURN p.name AS name" { "name":"the person" } {} |
There was a problem hiding this comment.
can we make the query simpler? does it need to be that long? (applies to other places too)
There was a problem hiding this comment.
I made this way for making it easier to figure out what's going on.
| self.assertEqual(eager_result.keys, ["n"]) | ||
| self.assertEqual(eager_result.records, [ | ||
| types.Record(values=[types.CypherInt(1)])]) | ||
| self.assertIsNotNone(eager_result.summary) |
There was a problem hiding this comment.
you could check the query included the summary
There was a problem hiding this comment.
I checked some fields, the summary is quite extensive. Maybe we could adapt the test_summary for testing the summary returned in the eager function.
Co-authored-by: Robsdedude <[email protected]>
Co-authored-by: Robsdedude <[email protected]>
bigmontz
force-pushed
the
5.x-execute-query
branch
from
225254d to
c5ca626
Compare
tests/stub/driver_execute_query/scripts/transaction_chaining.script
Outdated
Show resolved
Hide resolved
tests/stub/driver_execute_query/scripts/transaction_chaining_custom_bmm.script
Outdated
Show resolved
Hide resolved
Co-Authored-By: Rouven Bauer <[email protected]>
…ustom_bmm.script Co-authored-by: Robsdedude <[email protected]>
There was a problem hiding this comment.
Fine with me as is 🚀
One of my points didn't get discussed
#531 (comment)
But why do we even omit them?
SessionRune.g., always transmitsparams.
But I can make it work either way in the Python backend.
tests/stub/driver_execute_query/scripts/transaction_chaining_custom_bmm.script
Show resolved
Hide resolved
Co-authored-by: injectives <[email protected]>
No description provided.