Update and extend tests for connection_acquisition_timeout setting.
#474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests did not encompass routing drivers
bigmontz
requested changes
Jun 13, 2022
Also added a comment to avoid future changes to touch the port.
* `sessionConnectionTimeoutMs` * `updateRoutingTableTimeoutMs`
bigmontz
reviewed
Jun 20, 2022
tests/stub/driver_parameters/test_update_routing_table_timeout_ms.py
Outdated
Show resolved
Hide resolved
robsdedude
force-pushed
the
connection-acquisition-timeout-routing
branch
from
f62a2ae to
db41dec
Compare
This was referenced Jun 21, 2022
Merged
Skip timeout: connection acquisition timeout includes router handshake
neo4j/neo4j-dotnet-driver#623
Merged
robsdedude
added a commit
that referenced
this pull request
Jun 22, 2022
robsdedude
added a commit
that referenced
this pull request
Jun 22, 2022
|
Merging on red: JS flakiness (timed out), Python is expected to fail (see PR description + UTC fix pending) |
robsdedude
added a commit
that referenced
this pull request
Jun 23, 2022
Backport of #474 and #404 [ADR 006](https://github.com/neo-technology/drivers-adr/blob/main/adrs/006-acquisition-timeouts.md) * Update and extend tests for `connection_acquisition_timeout` setting. Tests did not encompass routing drivers * Add new timeout driver config options * `sessionConnectionTimeoutMs` * `updateRoutingTableTimeoutMs` * Add new feature flag * `API_CONNECTION_ACQUISITION_TIMEOUT = Feature:API:ConnectionAcquisitionTimeout"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests did not encompass routing drivers
Python is expected to fail until this pr is merged
This PR adds tests for ADR 006 (internal link).