Add tests for Bolt fix for broken DateTime encoding #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
bolt-utc-datetime
branch
from
36e2df1 to
ece6850
Compare
robsdedude
force-pushed
the
bolt-utc-datetime
branch
from
db15617 to
28b649e
Compare
robsdedude
force-pushed
the
bolt-utc-datetime
branch
from
e9e7f74 to
1df5d20
Compare
|
Just to note, some 4.4 routing tests seem to fail because |
In this case, we don't need for checking the presence of the patch, but just ignore if it's present. Co-authored-by: Florent Biville <[email protected]> Co-authored-by: Rouven Bauer <[email protected]>
In this case, we don't need for checking the presence of the patch, but just ignore if it's present. Co-authored-by: Florent Biville <[email protected]>
|
This version works with Java driver neo4j/neo4j-java-driver#1247. |
robsdedude
force-pushed
the
bolt-utc-datetime
branch
2 times, most recently
from
d22f5ee to
1c1b2d0
Compare
robsdedude
force-pushed
the
bolt-utc-datetime
branch
from
1c1b2d0 to
4d42bad
Compare
injectives
approved these changes
Jun 20, 2022
bigmontz
added a commit
that referenced
this pull request
Jun 21, 2022
The structures with signature `0x46` and `0x66` are being replaced by `0x49` and `0x69`. This new structures changes the meaning of seconds and nano seconds from `adjusted Unix epoch` to `UTC`. This changes have with goal of avoiding un-existing or ambiguous ZonedDateTime to be received or sent over Bolt. Bolt v4.3 and v4.4 were patched to support this feature if the server supports the patch. Co-authored-by: Antonio Barcelos <[email protected]> Co-authored-by: grant lodge <[email protected]> Co-authored-by: Florent Biville <[email protected]> Co-authored-by: Dmitriy Tverdiakov <[email protected]>
bigmontz
added a commit
that referenced
this pull request
Jun 22, 2022
The structures with signature `0x46` and `0x66` are being replaced by `0x49` and `0x69`. This new structures changes the meaning of seconds and nano seconds from `adjusted Unix epoch` to `UTC`. This changes have with goal of avoiding un-existing or ambiguous ZonedDateTime to be received or sent over Bolt. Bolt v4.3 and v4.4 were patched to support this feature if the server supports the patch. Co-authored-by: Rouven Bauer <[email protected]> Co-authored-by: grant lodge <[email protected]> Co-authored-by: Florent Biville <[email protected]> Co-authored-by: Dmitriy Tverdiakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Add tests for Bolt fix for broken DateTime encoding (#470) #476