Skip to content

🎉 Added new icon ArrowsAllDirections #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Aug 7, 2025

Description

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

@KenAJoh KenAJoh requested a review from Copilot August 7, 2025 11:07
Copy link

changeset-bot bot commented Aug 7, 2025

🦋 Changeset detected

Latest commit: 5b57a18

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new icon called "ArrowsAllDirections" to the icon library. The icon is categorized under "Arrows" and includes keywords in both Norwegian and English for movement and directional actions.

  • Added ArrowsAllDirections icon with appropriate metadata
  • Updated timestamps for existing icons (Percent and HourglassTopFilled)
  • Created changeset for version tracking

Reviewed Changes

Copilot reviewed 4 out of 12 changed files in this pull request and generated 4 comments.

File Description
@navikt/aksel-icons/icons/ArrowsAllDirections.yml Defines the new ArrowsAllDirections icon with metadata, keywords, and timestamps
@navikt/aksel-icons/icons/Percent.yml Updates the timestamp to reflect recent changes
@navikt/aksel-icons/icons/HourglassTopFilled.yml Updates the timestamp to reflect recent changes
.changeset/sweet-areas-ask.md Documents the new icon addition for version tracking

Comment on lines +14 to +15
updated_at: 07.08.2025
created_at: 07.08.2025
Copy link
Preview

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated_at date (07.08.2025) is set to a future date. This should be set to the current date when the icon was actually created or updated.

Suggested change
updated_at: 07.08.2025
created_at: 07.08.2025
updated_at: 07.06.2024
created_at: 07.06.2024

Copilot uses AI. Check for mistakes.

Comment on lines +14 to +15
updated_at: 07.08.2025
created_at: 07.08.2025
Copy link
Preview

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The created_at date (07.08.2025) is set to a future date. This should be set to the current date when the icon was actually created.

Suggested change
updated_at: 07.08.2025
created_at: 07.08.2025
updated_at: 08.06.2024
created_at: 08.06.2024

Copilot uses AI. Check for mistakes.

@@ -5,5 +5,5 @@ keywords:
- "%"
- prosent
variant: Stroke
updated_at: 14.05.2025
updated_at: 06.08.2025
Copy link
Preview

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated_at date (06.08.2025) is set to a future date. This should be set to the current date when the icon was actually updated.

Suggested change
updated_at: 06.08.2025
updated_at: 08.06.2024

Copilot uses AI. Check for mistakes.

@@ -13,5 +13,5 @@ keywords:
- fremdrift
- nedtelling
variant: Stroke
updated_at: 14.05.2025
updated_at: 06.08.2025
Copy link
Preview

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated_at date (06.08.2025) is set to a future date. This should be set to the current date when the icon was actually updated.

Suggested change
updated_at: 06.08.2025
updated_at: 06.06.2024

Copilot uses AI. Check for mistakes.

Copy link
Contributor

github-actions bot commented Aug 7, 2025

Storybook demo / Chromatic

20417ac09 | 92 components | 140 stories

@KenAJoh KenAJoh closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant