Skip to content

Conversation

sawyerh
Copy link
Contributor

@sawyerh sawyerh commented Oct 31, 2022

Context for reviewers

  • A code comment indicated the Babel config was needed for our tests to work, which may have been accurate at a certain point, but no longer is now that our Jest setup utilizes the next/jest package. More context here.
  • It appears that the Babel config was also allowing us to write the Storybook config in TypeScript, but we can still support type checking of that file without Babel (see file changes).
  • Now that the Babel config isn't present, Next.js and Jest will utilize SWC instead of Babel, which is supposed to result in improved performance.

Testing

Type checking still works in the Storybook JS config file:

CleanShot 2022-10-31 at 16 35 53@2x

@sawyerh sawyerh requested a review from aligg October 31, 2022 23:46
@sawyerh sawyerh merged commit 346574a into main Nov 1, 2022
@sawyerh sawyerh deleted the remove-babel branch November 1, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants