Remove infra components from nextjs template. #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Nice, side note: at some point we should finalize the discussion on installation instructions then add those to these template repos.
Merged
jimmyfagan
added a commit
that referenced
this pull request
Oct 7, 2022
## Ticket #6, this is the second PR because I missed a few files that can safely be deleted at this point. First PR is [here](#48 (comment)). ## Changes The only changes here are the deletion of image files that were referenced in infra README which was removed in PR #48. ## Context for reviewers See PR #48 ## Testing Ran `npm run test` and `npm run dev` to ensure I didn't mess anything up inadvertently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #6
Changes
This PR involved removing the
infrafolder from this template, and removing references to it from the README file, replacing them with reference to thetemplate-infrarepo. There were also formatting updates that my IDE made on the README that all seemed like good changes that won't affect the rendered Markdown.Context for reviewers
You probably have more context than I do, but basically since the
template-infrarepo was created to be common infrastructure regardless of type of application, we don't want to also haveinfrain this template.Testing
Tested this by running
npm run devagain and observing that the default template looks the same. Also re-rannpm run testfor good measure.