Skip to content

Conversation

sawyerh
Copy link
Contributor

@sawyerh sawyerh commented Apr 18, 2024

Resolves #312

@sawyerh sawyerh requested a review from rylew1 April 18, 2024 23:48
Copy link

github-actions bot commented Apr 18, 2024

Coverage report for app

St.
Category Percentage Covered / Total
🟢 Statements
93.1% (+0.08% 🔼)
81/87
🟢 Branches 82.35% 14/17
🟢 Functions 93.33% 14/15
🟢 Lines
93.59% (+0.08% 🔼)
73/78

Test suite run success

16 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 741d8ec

@sawyerh sawyerh requested a review from a team April 23, 2024 23:04
@sawyerh sawyerh merged commit 207b36f into main Apr 24, 2024
@sawyerh sawyerh deleted the sawyerh/server-only branch April 24, 2024 01:21
@rylew1
Copy link
Contributor

rylew1 commented Apr 25, 2024

Thanks for picking this one up @sawyerh !

Would it make sense for the route handler to also be marked server only? Though it's not really accessing anything secure at the moment.

@sawyerh
Copy link
Contributor Author

sawyerh commented Apr 25, 2024

@rylew1 Are you referring to api/hello/route.ts? My understanding is these only run on the server already.

@rylew1
Copy link
Contributor

rylew1 commented Apr 26, 2024

Yea nvm then - I was just looking for other places where it might be used but where you have it on the evidently code might be the only place - or the only place where things might be inadvertently imported into a client component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server-only package ?
3 participants