Skip to content

Conversation

sawyerh
Copy link
Contributor

@sawyerh sawyerh commented Aug 17, 2023

Ticket

Resolves #193

Context for reviewers

See context in #193

@sawyerh sawyerh changed the title Remove eslint-config-nava Remove eslint-config-nava in favor of eslint:recommended and Next.js built-in lint config Aug 17, 2023
@sawyerh sawyerh requested review from rocketnova, lorenyu and a team August 17, 2023 00:24
Copy link
Contributor

@lorenyu lorenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a minor enough of a change not to require an ADR. Maybe include some of the context in the squash commit description (optional)?

@sawyerh sawyerh merged commit d67e767 into main Aug 17, 2023
@sawyerh sawyerh deleted the sawyerh/193-remove-nava-eslint branch August 17, 2023 15:11
@aligg
Copy link
Contributor

aligg commented Aug 17, 2023

Belatedly came to review this - just wanted to say I read the context in the ticket and this change makes a lot of sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove eslint-config-nava dependency
3 participants