Set default i18n namespace to fix slow Storybook+Chromatic behavior #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
approved these changes
Aug 4, 2023
daphnegold
added a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Aug 21, 2023
daphnegold
added a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
translation.jsonwhich is the defaultnswhen it's not defined in the config.Context for reviewers
https://www.i18next.com/overview/configuration-options#languages-namespaces-resources
Testing
Before, in Chromatic
It would make several attempts to load the translation file, and would only render the story after six failed requests:
After, in Chromatic
No errors, and the Story loads right away