Block search engines from indexing Storybook #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
approved these changes
Jul 13, 2023
app/.storybook/main.js
Outdated
| function blockSearchEnginesInHead(head) { | ||
| return ` | ||
| ${head} | ||
| <meta name="robots" content="none"> |
There was a problem hiding this comment.
more for my own curiosity, is it stylistically preferrable to do self-closing tag like <meta .../> or is it better to be concise like <meta>
There was a problem hiding this comment.
Timely question, you just reminded me of this recent spicy post that argued against self-closing tags since they're meaningless in HTML and are an artifact from XML. Pretty divisive topic it seems 😅 I might switch this to self-closing to be consistent with how Prettier formats tags though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #155
Context for reviewers
Testing