Skip to content

Improve server version semver handling #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Improve server version semver handling #679

merged 1 commit into from
Mar 25, 2025

Conversation

robinbowes
Copy link
Contributor

@robinbowes robinbowes commented Mar 24, 2025 •
edited
Loading

Match server version using the regex suggested on https://semver.org

Other changes:

  • adds prerelease and build properties
  • requires all of major, minor, patch elements to be present

@wallyqs wallyqs marked this pull request as ready for review March 24, 2025 23:51
@robinbowes robinbowes force-pushed the robin/server_version_handling branch from 2711d72 to dbddfc5 Compare March 24, 2025 23:57
@wallyqs wallyqs merged commit dbddfc5 into nats-io:main Mar 25, 2025
7 checks passed
@robinbowes robinbowes deleted the robin/server_version_handling branch March 25, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinbowes @wallyqs