Skip to content

Add tls_handshake_first option. #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 23, 2023
Merged

Add tls_handshake_first option. #511

merged 4 commits into from
Oct 23, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Oct 23, 2023 •
edited
Loading

This supported in the main server at the moment.

            await nc.connect(
                servers=['tls://127.0.0.1:4224'],
                tls_handshake_first=True,
            )

@wallyqs
Add test for tls handshake option
913933e 
Signed-off-by: Waldemar Quevedo <[email protected]>
@wallyqs
Add tls_handshake_option for connect
41252ee 
Signed-off-by: Waldemar Quevedo <[email protected]>
@wallyqs
Bump version
5a324c1 
Signed-off-by: Waldemar Quevedo <[email protected]>
@wallyqs
Formatting
6127b18 
Signed-off-by: Waldemar Quevedo <[email protected]>
@wallyqs wallyqs requested review from bruth and Jarema October 23, 2023 15:02
Jarema
Jarema approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wallyqs wallyqs merged commit 12fe022 into main Oct 23, 2023
@wallyqs wallyqs deleted the tls-handshake-first branch October 23, 2023 20:34
@wallyqs wallyqs mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

@bruth bruth Awaiting requested review from bruth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallyqs @Jarema