Skip to content

Remove msg from fut.cancel to ensure backward compatibility #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2023
Merged

Remove msg from fut.cancel to ensure backward compatibility #479

merged 1 commit into from
Aug 10, 2023

Conversation

raprek
Copy link
Contributor

@raprek raprek commented Aug 5, 2023

@raprek raprek changed the title Remove msg from fut.cancel to ensure ensure backward compatibility Remove msg from fut.cancel to ensure backward compatibility Aug 5, 2023
wallyqs
wallyqs approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit ce4d765 into nats-io:main Aug 10, 2023
@wallyqs wallyqs mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raprek @wallyqs