Skip to content

Fix possible race setting timer in kv.WatchFiltered#1879

Merged
piotrpio merged 1 commit intomainfrom
kv-timer-race
Jun 2, 2025
Merged

Fix possible race setting timer in kv.WatchFiltered#1879
piotrpio merged 1 commit intomainfrom
kv-timer-race

Conversation

@wallyqs
Copy link
Copy Markdown
Member

@wallyqs wallyqs commented May 30, 2025

Prevent panic in Subscribe callback when it receives messages before timer is setup properly.

Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs changed the title Fix possible race setting timer kv.WatchFiltered Fix possible race setting timer in kv.WatchFiltered May 30, 2025
@wallyqs wallyqs requested a review from piotrpio May 30, 2025 17:22
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 84.766% (+0.03%) from 84.739%
when pulling be8b2c3 on kv-timer-race
into abad5e6 on main.

Copy link
Copy Markdown
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit ebb52f1 into main Jun 2, 2025
7 checks passed
@piotrpio piotrpio deleted the kv-timer-race branch June 2, 2025 09:21
@piotrpio piotrpio mentioned this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants