(2.12) Include original subject in Nats-Stream-Source, use in counter sourcing map
#7081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cing map This fixes a potential footgun with counter sourcing whereby you may have a subject transform from a single stream with a wildcard source but a non-wildcard destination, i.e. `foo.>` into `bar`. Without this, we would not correctly track `foo.baz` and `foo.qux` separately, causing a consistency error. Signed-off-by: Neil Twigg <[email protected]>
| if len(fields) >= 3 { | ||
| origSubj = fields[2] | ||
| if len(fields) >= 5 { | ||
| origSubj = fields[4] |
There was a problem hiding this comment.
Should this remain compatible for non-2.12 source strings? If not longer or equal to 5, but longer than equal to 3, we would still use index 2?
There was a problem hiding this comment.
I considered this but wasn't sure if it was needed, counters won't be originating from pre-2.12 servers.
| if len(fields) >= 3 { | ||
| origSubj = fields[2] | ||
| if len(fields) >= 5 { | ||
| origSubj = fields[4] |
There was a problem hiding this comment.
Same here for compatibilty with previous/shorter version and during upgrades?
neilalexander
changed the title
Nats-Stream-Source, use in counter sourcing mapNats-Stream-Source, use in counter sourcing map
|
Typo, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential footgun with counter sourcing whereby you may have a subject transform from a single stream with a wildcard source but a non-wildcard destination, i.e.
foo.>intobar. Without this, we would not correctly trackfoo.bazandfoo.quxseparately, causing a consistency error.Signed-off-by: Neil Twigg [email protected]