-
Notifications
You must be signed in to change notification settings - Fork 48
ogma-cli: Auxiliary file does not match associated tutorial #343
Description
Description
The auxiliary file ogma-cli/examples/ros2-001-hello-ogma/expressions.json does not match the copy of the file included in the ROS 2 tutorial in the same folder.
Specifically, the file states the property in positive form:
"properties": [
{
"id": "TestOgma",
"formula": "input_value > 0",
"text": "input_value is greater than zero"
}
]whereas the tutorial states the negation:
"properties": [
{
"id": "TestOgma",
"formula": "input_value <= 0",
"text": "input_value shall always be lower than or equal to zero"
}
]The two versions should match.
Type
- Bug: Disagreement between two mentions of the same information.
Additional context
None.
Requester
- Ivan Perez.
Method to check presence of bug
Compare the contents of the expressions.json file included in the "Expressions" subsection of ogma-cli/examples/ros2-001-hello-ogma/README.md with the file ogma-cli/examples/ros2-001-hello-ogma/expressions.json. The two should be the same.
Expected result
The contents of ogma-cli/examples/ros2-001-hello-ogma/expressions.json is in agreement with any information included of it ogma-cli/examples/ros2-001-hello-ogma/README.md.
Desired result
The contents of ogma-cli/examples/ros2-001-hello-ogma/expressions.json is in agreement with any information included of it ogma-cli/examples/ros2-001-hello-ogma/README.md.
Proposed solution
Modify ogma-cli/examples/ros2-001-hello-ogma/expressions.json to match the way the property is stated in ogma-cli/examples/ros2-001-hello-ogma/README.md.
Further notes
None.