`ogma-core`: cFS template has tab characters

[ivanperez-keera]

Description

The cFS template has tab characters, but shouldn't. Tab characters make it harder for alignment in code to remain consistent across developers, and are highly discouraged or forbidden by style guides, including Ogma's.

Type

• Bug: Code does not meet style guide.

Additional context

None.

Requester

• Ivan Perez.

Method to check presence of bug

Running the following grep command brings up a few occurrences of tabs in the cFS template:

$ grep -nHrP '\t' ogma-core/templates/copilot-cfs/
ogma-core/templates/copilot-cfs/fsw/src/copilot_cfs.c:147:			"COPILOT: invalid command packet,MID = 0x%x", MsgId);
ogma-core/templates/copilot-cfs/fsw/platform_inc/copilot_cfs_msgids.h:15:#define COPILOT_CFS_CMD_MID            	0x1882
ogma-core/templates/copilot-cfs/fsw/platform_inc/copilot_cfs_msgids.h:16:#define COPILOT_CFS_SEND_HK_MID        	0x1883
ogma-core/templates/copilot-cfs/fsw/platform_inc/copilot_cfs_msgids.h:17:#define COPILOT_CFS_HK_TLM_MID		0x0883

Expected result

The cFS template contains no tabs. Running the grep command above shows no results.

Desired result

The cFS template contains no tabs. Running the grep command above shows no results.

Proposed solution

Remove tabs from cFS templates. Align code appropriately.

Further notes

None.

[ivanperez-keera]

Change Manager: Confirmed that the issue exists.

[ivanperez-keera]

Technical Lead: Confirmed that the issue should be addressed.

[ivanperez-keera]

Technical Lead: Issue scheduled for fixing in Ogma 1.10.0.

Fix assigned to: @ivanperez-keera .