Skip to content

833 improve adac#835

Open
msuder wants to merge 5 commits intodevfrom
833-improve-adac
Open

833 improve adac#835
msuder wants to merge 5 commits intodevfrom
833-improve-adac

Conversation

@msuder
Copy link
Copy Markdown
Contributor

@msuder msuder commented Feb 25, 2026

Summary of PR goals.

How to test?

  • Run NOS3 via make launch
  • Click OK on the COSMOS splash screen
  • Click COSMOS to start the COSMOS command and telemetry server, the command sender and the packet viewer.
  • Click Test Runner
  • Select the Test Suite Generic_adcs_Test in the Test Runner and click Start to run this test suite
  • Verify that the test suite finishes successfully

Submodule PRs and actions prior to closing this:

Closes #833 .

@msuder msuder requested a review from zlynch2 February 25, 2026 20:53
@msuder msuder self-assigned this Feb 25, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.07%. Comparing base (842aa0e) to head (21e01e8).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #835      +/-   ##
==========================================
- Coverage   72.74%   72.07%   -0.67%     
==========================================
  Files         761      761              
  Lines       90262    91106     +844     
  Branches     7133     7292     +159     
==========================================
+ Hits        65664    65668       +4     
- Misses      24598    25438     +840     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as intended; the tests were much more reliable than before.

@zlynch2
Copy link
Copy Markdown
Collaborator

zlynch2 commented Mar 4, 2026

Passes cFS and cosmos side. still need to test Fprime since changed some shared files. So far so good.

@zlynch2
Copy link
Copy Markdown
Collaborator

zlynch2 commented Mar 6, 2026

Fprime doesnt build - due to adcs changes , need to address fprime compilation errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants