Clean up FpySequencer directives#4395

Merged

LeStarch merged 5 commits intonasa:develfrom

zimri-leisher:4394-fpy-remove-dirs

Nov 12, 2025

Collaborator

zimri-leisher commented Nov 5, 2025 •

edited

Loading


*Related Issue(s)*	#4394
*Has Unit Tests (y/n)*	y
*Documentation Included (y/n)*	y
*Generative AI was used in this contribution (y/n)*	y

Change Description

Remove the ASSERT and FLOAT_FLOOR_DIV directives, which can be replaced with combinations of other dirs.
Rename IADD to ADD, ISUB to SUB and IMUL to MUL

Rationale

This keeps the bytecode simple and consistent with other bytecodes.

AI Usage (see policy)

Updated docs, renamed bytecode ops


          Remove assert and float floor div

6b2e834

zimri-leisher requested a review from LeStarch

November 5, 2025 03:58

zimri-leisher self-assigned this

zimri-leisher added the Fpy label

zimri-leisher added 2 commits

November 4, 2025 22:59


          Merge branch 'devel' of github.com:zimri-leisher/fprime into 4394-fpy…

309d861

…-remove-dirs


          Rename add/sub/mul

15746d5

zimri-leisher changed the title ~~Remove assert and float floor div from FpySequencer~~ Clean up FpySequencer directives

github-advanced-security bot found potential problems

View reviewed changes

Svc/FpySequencer/FpySequencerDirectives.cpp

    
                      case Fpy::DirectiveId::IADD:

                          error = this->op_iadd();

                      case Fpy::DirectiveId::ADD:

                          error = this->op_add();

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter error has not been checked.

Svc/FpySequencer/FpySequencerDirectives.cpp

    
                      case Fpy::DirectiveId::IADD:

                          error = this->op_iadd();

                      case Fpy::DirectiveId::ADD:

                          error = this->op_add();

Check warning

Code scanning / CodeQL

Unchecked return value Warning

The return value of non-void function

is not checked.

Svc/FpySequencer/FpySequencerDirectives.cpp

    
                      case Fpy::DirectiveId::ISUB:

                          error = this->op_isub();

                      case Fpy::DirectiveId::SUB:

                          error = this->op_sub();

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter error has not been checked.

Svc/FpySequencer/FpySequencerDirectives.cpp

    
                      case Fpy::DirectiveId::ISUB:

                          error = this->op_isub();

                      case Fpy::DirectiveId::SUB:

                          error = this->op_sub();

Check warning

Code scanning / CodeQL

Unchecked return value Warning

The return value of non-void function

is not checked.

Svc/FpySequencer/FpySequencerDirectives.cpp

    
                      case Fpy::DirectiveId::IMUL:

                          error = this->op_imul();

                      case Fpy::DirectiveId::MUL:

                          error = this->op_mul();

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter error has not been checked.

Svc/FpySequencer/FpySequencerDirectives.cpp

    
                      case Fpy::DirectiveId::IMUL:

                          error = this->op_imul();

                      case Fpy::DirectiveId::MUL:

                          error = this->op_mul();

Check warning

Code scanning / CodeQL

Unchecked return value Warning

The return value of non-void function

is not checked.

github-advanced-security bot found potential problems

View reviewed changes

Svc/FpySequencer/FpySequencerDirectives.cpp

                   return DirectiveError::NO_ERROR;
               }
-              DirectiveError FpySequencer::op_iadd() {
+              DirectiveError FpySequencer::op_add() {

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Svc/FpySequencer/FpySequencerDirectives.cpp

                   return DirectiveError::NO_ERROR;
               }
-              DirectiveError FpySequencer::op_isub() {
+              DirectiveError FpySequencer::op_sub() {

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Svc/FpySequencer/FpySequencerDirectives.cpp

                   return DirectiveError::NO_ERROR;
               }
-              DirectiveError FpySequencer::op_imul() {
+              DirectiveError FpySequencer::op_mul() {

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

LeStarch previously approved these changes

View reviewed changes


          Merge branch 'devel' into 4394-fpy-remove-dirs

96ce277

LeStarch dismissed their stale review via

96ce277

November 7, 2025 00:32

Collaborator Author

zimri-leisher commented Nov 7, 2025

@LeStarch what's going on with the builds here?


          Merge branch 'devel' into 4394-fpy-remove-dirs

01fed0b

LeStarch approved these changes

View reviewed changes

LeStarch merged commit 1c87278 into nasa:devel

73 of 82 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fpy